Wrong endpoint on the TLS secret example #5817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @yacinelazaar , if my understanding of https://traefik.slack.com/archives/C0CDT22PJ/p1573560589045800 is correct: the snippet you changed is referenced in https://docs.traefik.io/v2.0/routing/providers/kubernetes-crd/#middleware, and does not enable TLS: so the entry point has to be If you meant https://docs.traefik.io/routing/providers/kubernetes-crd/#tls, can you add |
This snippet provided in that section uses 'web' as an endpoint instead of 'websecure'.
dduportal
approved these changes
Nov 12, 2019
There was a problem hiding this comment.
As discussed with @yacinelazaar , the entrypoint is finally replaced (instead of added ) to stay coherent with https://docs.traefik.io/v2.0/user-guides/docker-compose/acme-tls/ for example.
LGTM 👍
ldez
added
bot/light-review
traefiker
removed
bot/light-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This snippet provided in that section uses 'web' as an endpoint instead of 'websecure'.
What does this PR do?
Motivation
More
Additional Notes