Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KV store providers (dynamic configuration only) #5899

Merged
merged 7 commits into from Nov 28, 2019

Conversation

@ldez
Copy link
Member

ldez commented Nov 27, 2019

What does this PR do?

Allows to use a KV store as source of dynamic configuration.

The following KV stores are supported:

  • Consul
  • etcd
  • Redis
  • ZooKeeper

Motivation

Fixes #5169, #4369

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Co-authored-by: Jean-Baptiste Doumenjou jb.doumenjou@gmail.com

@ldez ldez added this to the next milestone Nov 27, 2019
@ldez ldez added this to To review in v2 via automation Nov 27, 2019
@ldez ldez force-pushed the ldez:feature/kv branch 3 times, most recently from c99e2af to 627e727 Nov 27, 2019
Copy link
Contributor

jbdoumenjou left a comment

LGTM

@ldez ldez force-pushed the ldez:feature/kv branch 2 times, most recently from 0f6d0e1 to cdaed2e Nov 27, 2019
pkg/provider/aggregator/aggregator.go Outdated Show resolved Hide resolved
integration/resources/compose/redis.yml Outdated Show resolved Hide resolved
pkg/config/static/static_config.go Show resolved Hide resolved
Copy link
Member

dtomcej left a comment

LGTM
:shipit:

Copy link
Contributor

SantoDE left a comment

LGTM

@traefiker traefiker force-pushed the ldez:feature/kv branch from 9b8807e to d2d3ccf Nov 28, 2019
@traefiker traefiker merged commit 9b9f4be into containous:master Nov 28, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
semaphoreci The build passed on Semaphore.
Details
v2 automation moved this from To review to Done Nov 28, 2019
@ldez ldez deleted the ldez:feature/kv branch Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.