Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PassClientTLSCert middleware separators and formatting #5921

Merged
merged 9 commits into from Dec 9, 2019
Merged

fix: PassClientTLSCert middleware separators and formatting #5921

merged 9 commits into from Dec 9, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Dec 2, 2019 •
edited

What does this PR do?

Use , as separator for certificates in the header X-Forwarded-Tls-Client-Cert-Info as for the header X-Forwarded-Tls-Client-Cert

Motivation

Be homogeneous.

More

  • Added/updated tests
    - [ ] Added/updated documentation

Additional Notes

Closes #5919

@ldez ldez added this to To review in v2 via automation Dec 2, 2019
@traefiker traefiker added this to the 2.0 milestone Dec 2, 2019
@ldez ldez mentioned this pull request Dec 2, 2019
Closed
2 tasks
@ldez ldez requested a review from jbdoumenjou December 2, 2019 11:06
@ldez ldez force-pushed the fix/passtlsclientcert-separator branch from 4147d10 to 5f9cc7f Compare December 2, 2019 11:31
@ldez ldez changed the title fix: incorrect separator for X-Forwarded-Tls-Client-Cert. fix: incorrect separator for X-Forwarded-Tls-Client. Dec 2, 2019
@ldez ldez changed the title fix: incorrect separator for X-Forwarded-Tls-Client. fix: incorrect separators for X-Forwarded-Tls-Client-Cert-Info. Dec 2, 2019
@ldez ldez force-pushed the fix/passtlsclientcert-separator branch from 5f9cc7f to 91325e1 Compare December 2, 2019 11:38
@jbdoumenjou jbdoumenjou force-pushed the fix/passtlsclientcert-separator branch from 6de4a7c to 7c54708 Compare December 2, 2019 13:43
@ldez ldez force-pushed the fix/passtlsclientcert-separator branch 6 times, most recently from eb83b07 to 89af4cd Compare December 3, 2019 18:32
@ldez ldez changed the title fix: incorrect separators for X-Forwarded-Tls-Client-Cert-Info. fix: PassClientTLSCert middleware separators and formating Dec 3, 2019
@ldez ldez changed the title fix: PassClientTLSCert middleware separators and formating fix: PassClientTLSCert middleware separators and formatting Dec 3, 2019
dtomcej
dtomcej approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

jbdoumenjou
jbdoumenjou approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez requested a review from mpl December 6, 2019 23:30
@traefiker traefiker force-pushed the fix/passtlsclientcert-separator branch from 48fac13 to 243121c Compare December 9, 2019 10:58
@traefiker traefiker merged commit 39a3cef into traefik:v2.0 Dec 9, 2019
v2 automation moved this from To review to Done Dec 9, 2019
@ldez ldez deleted the fix/passtlsclientcert-separator branch December 9, 2019 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpl mpl mpl approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/middleware kind/bug/fix a bug fix size/M
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @mpl @jbdoumenjou @dtomcej @traefiker