New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle respondingTimeout and better shutdown tests. #6115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliens
force-pushed
the
fix-respondingtimeout
branch
2 times, most recently
from
December 31, 2019 13:47
0bd29ce
to
a1c6b85
Compare
mpl
requested changes
Jan 2, 2020
mpl
approved these changes
Jan 3, 2020
dtomcej
approved these changes
Jan 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ldez
approved these changes
Jan 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-Authored-By: mpl <mathieu.lonjaret@gmail.com>
traefiker
force-pushed
the
fix-respondingtimeout
branch
from
January 6, 2020 15:28
c778845
to
c8b479d
Compare
ldez
changed the title
Handle respondingtimeout and better shutdown tests.
Handle respondingTimeout and better shutdown tests.
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR handles the
RespondingTimeout
options and improveShutdown
.Motivation
Fixes #5763
More
- [ ] Added/updated documentationCo-authored-by: Mathieu Lonjaret mathieu.lonjaret@gmail.com