Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle respondingTimeout and better shutdown tests. #6115

Merged
merged 5 commits into from Jan 6, 2020

Conversation

juliens
Copy link
Member

@juliens juliens commented Dec 31, 2019

What does this PR do?

This PR handles the RespondingTimeout options and improve Shutdown.

Motivation

Fixes #5763

More

  • Added/updated tests
    - [ ] Added/updated documentation

Co-authored-by: Mathieu Lonjaret mathieu.lonjaret@gmail.com

@traefiker traefiker added this to the 2.1 milestone Dec 31, 2019
@juliens juliens force-pushed the fix-respondingtimeout branch 2 times, most recently from 0bd29ce to a1c6b85 Compare December 31, 2019 13:47
pkg/server/server_entrypoint_tcp.go Outdated Show resolved Hide resolved
pkg/server/server_entrypoint_tcp.go Outdated Show resolved Hide resolved
pkg/server/server_entrypoint_tcp.go Outdated Show resolved Hide resolved
pkg/server/server_entrypoint_tcp.go Outdated Show resolved Hide resolved
pkg/server/server_entrypoint_tcp.go Outdated Show resolved Hide resolved
pkg/server/server_entrypoint_tcp.go Outdated Show resolved Hide resolved
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added this to To review in v2 via automation Jan 6, 2020
@traefiker traefiker merged commit 807dc46 into traefik:v2.1 Jan 6, 2020
v2 automation moved this from To review to Done Jan 6, 2020
@juliens juliens deleted the fix-respondingtimeout branch January 7, 2020 09:11
@ldez ldez changed the title Handle respondingtimeout and better shutdown tests. Handle respondingTimeout and better shutdown tests. Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants