Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ingress annotations support #6160

Merged
merged 4 commits into from Jan 14, 2020
Merged

Conversation

@ldez
Copy link
Member

ldez commented Jan 13, 2020

What does this PR do?

Add Ingress annotations support.

Motivation

Fixes #6074

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Co-authored-by: jbdoumenjou jb.doumenjou@gmail.com

@ldez ldez added this to To review in v2 via automation Jan 13, 2020
@traefiker traefiker added the size/L label Jan 13, 2020
@ldez ldez added this to the next milestone Jan 13, 2020
@ldez ldez force-pushed the ldez:feat/ingress-annotations branch 2 times, most recently from b229e43 to 4492e49 Jan 13, 2020
Copy link
Contributor

jbdoumenjou left a comment

LGTM

@mmatur
mmatur approved these changes Jan 14, 2020
Copy link
Member

mmatur left a comment

LGTM 👏

Copy link
Contributor

SantoDE left a comment

lgtm 👼

awesome job!

@traefiker traefiker force-pushed the ldez:feat/ingress-annotations branch from cabc81b to 86112fd Jan 14, 2020
@traefiker traefiker merged commit 6b7be46 into containous:master Jan 14, 2020
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
semaphoreci The build passed on Semaphore.
Details
v2 automation moved this from To review to Done Jan 14, 2020
@ldez ldez deleted the ldez:feat/ingress-annotations branch Jan 14, 2020
@ldez ldez mentioned this pull request Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v2
Done
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.