New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route all request to /api/* to api handler and Include request url in response #12

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@campbellr
Contributor

campbellr commented Oct 23, 2018

I used this for testing a reverse proxy, and it was extremely useful to see what the request url was when proxying arbitrary requests.

@emilevauge

This comment has been minimized.

Member

emilevauge commented Oct 25, 2018

@campbellr With #13, is this one still useful?

@campbellr

This comment has been minimized.

Contributor

campbellr commented Oct 25, 2018

Yeah, imo it is.

#13 only covers adding the host and method to the response, while this handles supporting arbitrary suburbs for the /api route (eg: /api/foo/bar) and including that url in the response.

I hope that clarifies it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment