New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continue in switch case deprecated since PHP 7.3 #24

Closed
Hammelpilaw opened this Issue Jan 27, 2019 · 2 comments

Comments

2 participants
@Hammelpilaw
Copy link

Hammelpilaw commented Jan 27, 2019

Frontend throws a warning:

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?

in ThemeImportListener.php line 90

Module version 2.1.1
Path to file: vendor/contao-bootstrap/grid/src/Listener/ThemeImportListener.php
You should use break or continue 2 in line 90.

continue without parameter in a switch case statement is deprecated since PHP 7.3 and will throw a compile error PHP 8.

@dmolineus dmolineus transferred this issue from contao-bootstrap/bundle Jan 28, 2019

@dmolineus dmolineus self-assigned this Jan 28, 2019

@dmolineus dmolineus added the bug label Jan 28, 2019

@dmolineus dmolineus added this to To do in Contao Bootstrap v2 via automation Jan 28, 2019

@dmolineus

This comment has been minimized.

Copy link
Member

dmolineus commented Jan 28, 2019

Thx for reporting. I transfered the issue to the right repository.

@dmolineus dmolineus added the ready label Jan 29, 2019

@dmolineus dmolineus added this to the 2.0.8 milestone Jan 29, 2019

dmolineus added a commit that referenced this issue Jan 29, 2019

@dmolineus

This comment has been minimized.

Copy link
Member

dmolineus commented Jan 29, 2019

Fixed in version 2.0.8.

@dmolineus dmolineus closed this Jan 29, 2019

Contao Bootstrap v2 automation moved this from To do to Done Jan 29, 2019

@dmolineus dmolineus removed the ready label Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment