Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if classes could be added to class key instead of the generic attributes key #34

Closed
dmolineus opened this issue Oct 18, 2019 · 1 comment
Closed

Check if classes could be added to class key instead of the generic attributes key #34

dmolineus opened this issue Oct 18, 2019 · 1 comment
Assignees
@dmolineus
Labels
bug
Projects
Contao Bootstrap v2
Milestone
2.1.2

Comments

@dmolineus
Copy link
Member

@dmolineus dmolineus commented Oct 18, 2019 •
edited

grid/src/Component/ContentElement/GalleryElement.php

Line 366 in d268e49

$cell->picture['attributes'] = 'class="img-fluid figure-img img-thumbnail"';

https://github.com/contao/contao/blob/0236382bf085f0a210409957c4b9c70c184f810b/core-bundle/src/Resources/contao/templates/picture/picture_default.html5#L11
@dmolineus dmolineus self-assigned this Oct 18, 2019
@dmolineus dmolineus added this to To do in Contao Bootstrap v2 via automation Oct 18, 2019
@dmolineus dmolineus added this to the 2.1.2 milestone Oct 18, 2019
@dmolineus dmolineus added bug and removed enhancement labels Nov 11, 2019
@dmolineus
Copy link
Member Author

@dmolineus dmolineus commented Nov 11, 2019

Fixed with 23d4436

Contao Bootstrap v2 automation moved this from To do to Done Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmolineus dmolineus

Labels
bug
Projects
Contao Bootstrap v2
  
Done
Milestone
2.1.2
Development

No branches or pull requests
1 participant
@dmolineus