Unterstützung für Größensuffixe bei Alignments#26
Merged
dmolineus merged 2 commits intocontao-bootstrap:developfrom Apr 8, 2019
RoflCopter24:patch-1
Merged
Unterstützung für Größensuffixe bei Alignments#26dmolineus merged 2 commits intocontao-bootstrap:developfrom RoflCopter24:patch-1
dmolineus merged 2 commits intocontao-bootstrap:developfrom
RoflCopter24:patch-1
Conversation
Im Backend kann man bei 'Gridgrößen und -spalten' bei jeder Größe 'Vertikale Ausrichtung' auswählen. Bei der Ausgabe wird dies jedoch nicht berücksichtigt, es wird für alle Größen immer nur 'align-self-end' anstatt 'align-self-xx-end' ausgegeben. Ich habe die entsprechenden Funktionen ergänzt, sodass nun die Größen wie md, lg usw. richtig ausgegeben werden sofern sie vorhanden sind.
Member
|
Nice, I somehow missed that theses classes are also size specific available. This project uses the contao-community-alliance coding standards which requires that each author is listed in the file header. Besides some alignments in the docs does not fit the coding standard. Would you please address this issues? You can check them local by running a composer update an |
Contributor
Author
|
Sure! The header has been added and phpcbf fixed some spaces. |
dmolineus
approved these changes
Apr 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Im Backend kann man bei 'Gridgrößen und -spalten' bei jeder Größe 'Vertikale Ausrichtung' auswählen.
Bei der Ausgabe wird dies jedoch nicht berücksichtigt, es wird für alle Größen immer nur mehrfach zum Beispiel
align-self-endanstattalign-self-xx-endausgegeben.Ich habe die entsprechenden Funktionen ergänzt, sodass nun die Größen wie md, lg usw. richtig ausgegeben werden sofern sie vorhanden sind.
Vorher:
ce_bs_gridSeparator col-12 align-self-center col-lg-6 align-self-endNachher:
ce_bs_gridSeparator col-12 align-self-center col-lg-6 align-self-lg-end