Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Separate template for gallery and removal of hardcoded css classes #41

Merged

Conversation

RoflCopter24
Copy link
Contributor

@RoflCopter24 RoflCopter24 commented Feb 25, 2020

Recently I had the issue that a project was using a heavily modified contao standard gallery and - when using the bootstrap grid gallery on another part of the site - it messed up the complete output of the grid and images.

So I propose, that - as the Bootstrap Grid Gallery is a separate content element anyway - it should use a separate template so that the internal contao template can be customized regardless of the bootstrap gallery.

Furthermore I think hard-coding CSS-Classes into an extension in a way that is inaccessible to the Enduser/Developer is not a good idea - I would rather have these classes supplied by the ImageSize.
What are your thoughts on that?

@RoflCopter24 RoflCopter24 requested a review from dmolineus Feb 25, 2020
Copy link
Member

@dmolineus dmolineus left a comment

I agree with the usage of an own template, but it should follow the naming rules of Contao. The correct name should be ce_bs_grid_gallery.

@dmolineus dmolineus added this to In progress in Contao Bootstrap v2 via automation Feb 26, 2020
@dmolineus dmolineus added this to the 2.3.0 milestone Feb 26, 2020
@dmolineus dmolineus self-assigned this Feb 26, 2020
@RoflCopter24
Copy link
Contributor Author

RoflCopter24 commented Feb 26, 2020

Excellent! I have changed the file name accordingly.

@dmolineus dmolineus changed the base branch from master to develop Aug 28, 2020
@dmolineus dmolineus changed the base branch from develop to master Aug 28, 2020
@dmolineus dmolineus changed the base branch from master to develop Aug 28, 2020
@dmolineus dmolineus merged commit c0359ee into contao-bootstrap:develop Aug 28, 2020
1 check passed
Contao Bootstrap v2 automation moved this from In progress to Done Aug 28, 2020
@dmolineus
Copy link
Member

dmolineus commented Aug 28, 2020

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants