Proposal: Separate template for gallery and removal of hardcoded css classes#41
Merged
dmolineus merged 5 commits intocontao-bootstrap:developfrom Aug 28, 2020
Conversation
dmolineus
requested changes
Feb 26, 2020
Member
dmolineus
left a comment
dmolineus
left a comment
There was a problem hiding this comment.
I agree with the usage of an own template, but it should follow the naming rules of Contao. The correct name should be ce_bs_grid_gallery.
Contributor
Author
|
Excellent! I have changed the file name accordingly. |
dmolineus
approved these changes
Feb 27, 2020
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently I had the issue that a project was using a heavily modified contao standard gallery and - when using the bootstrap grid gallery on another part of the site - it messed up the complete output of the grid and images.
So I propose, that - as the Bootstrap Grid Gallery is a separate content element anyway - it should use a separate template so that the internal contao template can be customized regardless of the bootstrap gallery.
Furthermore I think hard-coding CSS-Classes into an extension in a way that is inaccessible to the Enduser/Developer is not a good idea - I would rather have these classes supplied by the ImageSize.
What are your thoughts on that?