-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new template for responsive YT video #21
Comments
There should be probably different templates for each ratio |
I find rather inflexible... |
What do you suggest? |
we can use the same "magic function" like "img-fluid" to transfer the css class to the right div container... Edit: we can use the class "embed-responsive-16by9" as default and override this with magic function 16:9 is the standard https://support.google.com/youtube/answer/6375112?co=GENIE.Platform%3DDesktop&hl=de |
Since contao/core-bundle@0d0aba2#diff-800975046c3ea232e3dd2a377584899b Contao provides an aspect setting. I prefer using it with a customized template. Only drawback is, that's not available in Contao 4.4. |
o.k. - maybe we can use "embed-responsive-16by9" as default and everybody can override this template (and css class) |
I decided to backport the |
new template
The class
embed-responsive-16by9
should be passed from the outer div with ce_youtube to the iframe-enclosing divThe text was updated successfully, but these errors were encountered: