Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the number of events to the main template #32

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Pass the number of events to the main template #32

merged 1 commit into from
Jun 14, 2018

Conversation

aschempp
Copy link
Member

Necessary if I want to hide the list template alltogether if there are no events.

@leofeyer
Copy link
Member

Should we also pass $total? Then we'd cover contao/core#7825, wouldn't we?

@leofeyer leofeyer added this to the 4.6.0 milestone Jun 13, 2018
@aschempp
Copy link
Member Author

What does $total provide? The module settings (from tl_module) are already present in the template.

@leofeyer leofeyer mentioned this pull request Jun 13, 2018
Closed
@leofeyer
Copy link
Member

IDK. Does your PR solve contao/core#7825?

@aschempp
Copy link
Member Author

It does not, but the ticket is not correct. There's no counter of news in the news list, the template work totally different.

@leofeyer leofeyer merged commit 83ca281 into contao:master Jun 14, 2018
@leofeyer
Copy link
Member

Thank you @aschempp.

@aschempp aschempp deleted the feature/eventCount branch January 9, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aschempp aschempp

Labels
feature
Projects
None yet
Milestone
4.6
Development

Successfully merging this pull request may close these issues.
2 participants
@aschempp @leofeyer