Skip to content
This repository has been archived by the owner on Jan 2, 2020. It is now read-only.

add check for Contao 4.5 #139

Merged
merged 1 commit into from Feb 12, 2018
Merged

add check for Contao 4.5 #139

merged 1 commit into from Feb 12, 2018

Conversation

fritzmg
Copy link
Collaborator

@fritzmg fritzmg commented Feb 8, 2018

This adds a separate check for Contao 4.5, which checks for PHP 7.1.0 and checks the ICU library version for at least 4.6.

screenshot-2018-2-8 contao check 12 0

screenshot-2018-2-8 contao check 12 0 1

@leofeyer
Copy link
Member

leofeyer commented Feb 8, 2018

To remain consistency, there should be only one red error message, not a red line and a grey line below.

@fritzmg
Copy link
Collaborator Author

fritzmg commented Feb 8, 2018

To remain consistency, there should be only one red error message, not a red line and a grey line below.

But that is consistent.

screenshot-2018-2-8 contao check 12 0 2

@leofeyer
Copy link
Member

leofeyer commented Feb 8, 2018

Sorry, you are right. I did not recall correctly.

@fritzmg
Copy link
Collaborator Author

fritzmg commented Feb 10, 2018

I have updated the PR. The Contao 4.5 check now inherits from the Contao 4 check.

@fritzmg
Copy link
Collaborator Author

fritzmg commented Feb 12, 2018

@leofeyer what do you think, can this be merged?

@fritzmg fritzmg merged commit 9d69879 into master Feb 12, 2018
@fritzmg fritzmg deleted the contao45 branch February 12, 2018 12:23
@ausi
Copy link
Member

ausi commented Oct 3, 2018

@fritzmg we should probably update this check because since slug-generator version 1.0.2 the minimum ICU version is 4.2.1

@fritzmg
Copy link
Collaborator Author

fritzmg commented Oct 18, 2018

Technically ICU 4.2.0 would still work though, wouldn't it? In that case composer would (in theory) only install 1.0.1 of ausi/slug-generator, since Contao allows ^1.0.1.

// oh nvm, the new requirement is lower not higher 😬

fritzmg added a commit that referenced this pull request Oct 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants