This repository has been archived by the owner on Jan 2, 2020. It is now read-only.
add check for Contao 4.5 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ausi
approved these changes
Feb 8, 2018
To remain consistency, there should be only one red error message, not a red line and a grey line below. |
Sorry, you are right. I did not recall correctly. |
I have updated the PR. The Contao 4.5 check now inherits from the Contao 4 check. |
@leofeyer what do you think, can this be merged? |
leofeyer
approved these changes
Feb 12, 2018
@fritzmg we should probably update this check because since slug-generator version 1.0.2 the minimum ICU version is 4.2.1 |
Technically ICU // oh nvm, the new requirement is lower not higher 😬 |
fritzmg
added a commit
that referenced
this pull request
Oct 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a separate check for Contao 4.5, which checks for PHP
7.1.0
and checks the ICU library version for at least4.6
.