Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete OpCode Cache #80

Closed
3 tasks
aschempp opened this issue May 10, 2017 · 6 comments
Closed
3 tasks

Delete OpCode Cache #80

aschempp opened this issue May 10, 2017 · 6 comments
Labels
Milestone

Comments

@aschempp
Copy link
Member

The manager must run opcache_reset()

  • after self-update
  • after package changes (require/remove/update)
  • maybe after ApiError?
@leofeyer
Copy link
Member

leofeyer commented May 10, 2017

This is what we should run:

        // Zend OPcache
        if (function_exists('opcache_reset')) {
            opcache_reset();
        }

        // APC
        if (function_exists('apc_clear_cache') && !ini_get('apc.stat')) {
            apc_clear_cache();
        }

@leofeyer
Copy link
Member

The code is taken from the Live Update client.

@aschempp
Copy link
Member Author

FYI this must also be done in the install tool…

@Toflar
Copy link
Member

Toflar commented May 11, 2017

Also, regarding the manager, this should be done in the web process, not via command line :) I know it might be obvious but leaving this here for reference.

@leofeyer
Copy link
Member

leofeyer commented May 18, 2017

Implemented in the install tool in contao/installation-bundle@68293bf.

leofeyer added a commit to contao/installation-bundle that referenced this issue May 18, 2017
leofeyer added a commit to contao/installation-bundle that referenced this issue May 18, 2017
@leofeyer
Copy link
Member

Please note my adjusted comment above. I have removed all caches that are no longer maintained or not compatible with PHP 5.6 (let alone PHP 7).

@aschempp aschempp added this to the 1.0.0 milestone Jun 7, 2017
@aschempp aschempp added the bug label Jun 7, 2017
@aschempp aschempp closed this as completed Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants