New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove target="_blank" from the back end links #387

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@leofeyer
Copy link
Member

leofeyer commented Jan 9, 2019

As discussed in the last call, we want the links from the back end to the Contao Manager and from the Contao Manager to the back end to open in the same window. People can still open links without target="_blank" in new tabs if they want, but they cannot open links with target="_blank" in the same tab if they want.

@aschempp

This comment has been minimized.

Copy link
Contributor

aschempp commented Jan 10, 2019

This however also affects people without Contao 4.7 so they will not have a back link? Also, should we add the Manager link to the install tool then? And I think the front end should stay on new window?

@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Jan 10, 2019

People can still open links without target="_blank" in new tabs if they want, but they cannot open links with target="_blank" in the same tab if they want, therefore we should think carefully when to use target="_blank".

And I think the front end should stay on new window?

Agreed.

@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment