Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODOs left for Contao 4.9.0 #1309

Closed
leofeyer opened this issue Feb 11, 2020 · 3 comments
Closed

TODOs left for Contao 4.9.0 #1309

leofeyer opened this issue Feb 11, 2020 · 3 comments
Assignees
Labels
Milestone

Comments

@leofeyer
Copy link
Member

@leofeyer leofeyer commented Feb 11, 2020

  • Consistently use "backup codes" instead of "recovery codes" (see #1320)
  • Check if disabling 2FA clears the backup codes and trusted devices (see #1322)
  • Adjust the SERP widget to the new Google design (see #1323)
  • Fix rendering the picker preview (see #1327)

@leofeyer leofeyer self-assigned this Feb 11, 2020
@leofeyer leofeyer added the defect label Feb 11, 2020
@leofeyer leofeyer added this to the 4.9 milestone Feb 11, 2020
@asaage

This comment has been minimized.

Copy link

@asaage asaage commented Feb 11, 2020

Adjust the SERP widget to the new Google design (and maybe rename it to "SERP preview" without "Google" again?)

do you really want to keep up with googles designchanges?
they went from no-favicons, green-urls to favicons with breadcrumbs and no green at all and back to no favicons within a couple of weeks. And i assume the widget doesn't even consider richsnippets which google might find on the site.
Apart from that google often does not even use the meta-description but text that is more appropiate and in neighbourhood of the search-term.

@contaoacademy

This comment has been minimized.

Copy link

@contaoacademy contaoacademy commented Feb 11, 2020

Ich fände es schön, wenn der Text der Checkbox beim Crawler "Nach kaputten Links suchen" noch anders benannt wird.
Das Wort "kaputt" ist umgangssprachlich.

Wie wäre es mit "Nach fehlerhaften oder defekten Links suchen"

leofeyer added a commit that referenced this issue Feb 13, 2020
leofeyer added a commit that referenced this issue Feb 13, 2020
leofeyer added a commit that referenced this issue Feb 13, 2020
leofeyer added a commit that referenced this issue Feb 13, 2020
Description
-----------

See #1309

Commits
-------

1afb5dd Replace "recovery codes" with "backup codes" (see #1309)
@leofeyer

This comment has been minimized.

Copy link
Member Author

@leofeyer leofeyer commented Feb 13, 2020

Wie wäre es mit "Nach fehlerhaften oder defekten Links suchen"

Ich habe die deutsche Übersetzung entsprechend angepasst.

leofeyer added a commit that referenced this issue Feb 14, 2020
leofeyer added a commit that referenced this issue Feb 14, 2020
@leofeyer leofeyer closed this Feb 14, 2020
leofeyer pushed a commit that referenced this issue Feb 14, 2020
Description
-----------

See #1309.

Commits
-------

5ecf127 Clear trusted devices when disabling 2fa
63ae617 Add more checks
leofeyer added a commit that referenced this issue Feb 14, 2020
Description
-----------

See #1309 

### Before

<img width="848" alt="" src="https://user-images.githubusercontent.com/1192057/74519736-940d5d00-4f16-11ea-87ca-969efdae5da0.png">

### After

<img width="789" alt="" src="https://user-images.githubusercontent.com/1192057/74519748-996aa780-4f16-11ea-82ca-385ce2362eef.png">

Commits
-------

a96b5a6 Fix rendering the picker preview (see #1309)
95f3ce4 Limit the overall height of the preview content
leofeyer added a commit that referenced this issue Feb 14, 2020
Description
-----------

See #1309

The PR turns the old design with the green URL

<img width="668" alt="" src="https://user-images.githubusercontent.com/1192057/74461149-58c74b80-4e8e-11ea-80dc-d368964b2f35.png">

into the new design with the breadcrumb trail

<img width="657" alt="" src="https://user-images.githubusercontent.com/1192057/74461185-6a105800-4e8e-11ea-8491-2ae418abbf85.png">

so the widget shows the Google search results as accurate as possible.

Commits
-------

748f25f Adjust the SERP widget to the Google search results (see #1309)
994dd83 Re-minify the style sheet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.