Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels for min and max value in form field settings #437

Closed
Toflar opened this issue Apr 15, 2019 · 9 comments

Comments

@Toflar
Copy link
Member

commented Apr 15, 2019

Affected version(s)

4.7.*

Description

I think the labels for minimum and maximum value in the form field generator are a bit misleading. See:
grafik-20190415-120244

I think it's the same in English because we re-use the minlength and maxlength labels. Imho those should get adjusted in an onload_callback or so here otherwise it's super misleading (my customers keep entering 4 and 5 to restrict postal code lengths).

@fritzmg

This comment has been minimized.

Copy link
Collaborator

commented Apr 15, 2019

I made the same mistake recently 😁

@leofeyer

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

my customers keep entering 4 and 5 to restrict postal code lengths

What is wrong with that?

@Toflar

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2019

It won't work. The minlength and maxlength fields are abused for min and max attributes. The other two have no effect on input type="number" fields. So what they should enter instead is 1000 and 99999.

@leofeyer

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Ok, that is wrong for sure. 😄

@leofeyer leofeyer added the defect label Apr 30, 2019

@leofeyer leofeyer added this to the 4.4.40 milestone Apr 30, 2019

@Toflar

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2019

4.7.* only ;)

@leofeyer leofeyer modified the milestones: 4.4.40, 4.7.6 Apr 30, 2019

@leofeyer

This comment has been minimized.

Copy link
Member

commented May 13, 2019

I would suggest reverting f7a5ff7 and adding two fields tl_form_field.minval and tl_form_field.maxval. Then we can translate them separately and we do not have any "changes its meaning depending on the field type" magic. WDYT?

@Toflar

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

Sounds good to me, wdyt @qzminski ?

@qzminski

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Yep, agreed 👍

@leofeyer leofeyer self-assigned this Jul 16, 2019

leofeyer added a commit that referenced this issue Jul 16, 2019

@leofeyer leofeyer modified the milestones: 4.7, 4.8 Jul 16, 2019

leofeyer added a commit that referenced this issue Jul 16, 2019
leofeyer added a commit that referenced this issue Jul 16, 2019
@leofeyer

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

Changed in 0da382f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.