Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the "resname" attribute in .xliff files #556

Open
leofeyer opened this issue Jul 5, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@leofeyer
Copy link
Member

commented Jul 5, 2019

As described in the Xliff wiki, the original identifier of a text item should be stored in the resname attribute of the <trans-unit> tag. We are currently (ab)using the id attribute, which is why the Contao .xliff files are not compatible with the Symfony translator (see symfony/symfony#12241).

We should adjust our Xliff loader to handle the attribute and update our .xliff files accordingly.

@leofeyer leofeyer added the defect label Jul 5, 2019

@leofeyer leofeyer added this to the 4.9 milestone Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.