New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the default of some fields #56

Open
leofeyer opened this Issue Sep 12, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@leofeyer
Member

leofeyer commented Sep 12, 2018

See #20 (comment)

That's a bad example, because storing 4 instead of 0 does not affect the database size. But here are some fields we do need to fix:

  • tl_content.sliderSpeed stores 300 in every row (should be 0)
  • tl_module.queryType stores and in every row (should be '')
  • tl_module.searchType stores simple in every row (should be '')
  • tl_page.sitemap stores map_default in every row (should be '')

However, we should open a separate ticket hereto.

@aschempp

This comment has been minimized.

Show comment
Hide comment
@aschempp

aschempp Sep 12, 2018

Contributor

We have discussed this before, if I remember correctly. This is how the DCA works, and I don't see a way to change it. We must have these defaults, otherwise defaults do not make sense at all.

Contributor

aschempp commented Sep 12, 2018

We have discussed this before, if I remember correctly. This is how the DCA works, and I don't see a way to change it. We must have these defaults, otherwise defaults do not make sense at all.

@leofeyer

This comment has been minimized.

Show comment
Hide comment
@leofeyer

leofeyer Sep 12, 2018

Member

We must have the defaults, yes, but we must not add them to every row in the table.

Member

leofeyer commented Sep 12, 2018

We must have the defaults, yes, but we must not add them to every row in the table.

@aschempp

This comment has been minimized.

Show comment
Hide comment
@aschempp

aschempp Sep 12, 2018

Contributor

That's not possible imho, otherwise you would need to update defaults when I switch the type, based on whether the field is in the palette. And also if the user has permission. But if she does not have permission, you still need to add the default. etc…

Contributor

aschempp commented Sep 12, 2018

That's not possible imho, otherwise you would need to update defaults when I switch the type, based on whether the field is in the palette. And also if the user has permission. But if she does not have permission, you still need to add the default. etc…

@leofeyer

This comment has been minimized.

Show comment
Hide comment
@leofeyer

leofeyer Sep 12, 2018

Member

Let's try and see, shall we?

Member

leofeyer commented Sep 12, 2018

Let's try and see, shall we?

@ausi

This comment has been minimized.

Show comment
Hide comment
@ausi

ausi Sep 12, 2018

Member

I don’t see why we have to remove these defaults for database size. Did you test how big the effect of these default values is regarding storage size?

We have discussed this before, if I remember correctly.

AFAIR we discussed it in the Mumble call, see contao/core#8075 (comment)

Member

ausi commented Sep 12, 2018

I don’t see why we have to remove these defaults for database size. Did you test how big the effect of these default values is regarding storage size?

We have discussed this before, if I remember correctly.

AFAIR we discussed it in the Mumble call, see contao/core#8075 (comment)

@leofeyer leofeyer removed this from the 4.4.25 milestone Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment