Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout should not remove the preview cookie #575

Open
leofeyer opened this issue Jul 11, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@leofeyer
Copy link
Member

commented Jul 11, 2019

Affected version(s)

4.8

Description

When logging out of the back end, the _contao_preview cookie is removed, so the only way to debug the login page is:

  • Log into the back end
  • Enable the debug mode
  • Manually remove the PHPSESSID cookie
  • Reload the page

We should not remove the _contao_preview cookie if the debug mode is enabled IMHO.

How to reproduce

Log into the back end, enable the debug mode and then log out. The debug bar is no longer shown.

@leofeyer leofeyer added the defect label Jul 11, 2019

@leofeyer leofeyer added this to the 4.8 milestone Jul 11, 2019

@aschempp

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

I don't think that's a good idea. The JWT setup is mean to only work if you are logged in to the back end. If you want to debug the login page, we should better implement something like #574

@leofeyer

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.