Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get universal picker url parameters via own method #1154

Merged
merged 2 commits into from Jan 7, 2020
Merged

Get universal picker url parameters via own method #1154

merged 2 commits into from Jan 7, 2020

Conversation

rabauss
Copy link
Contributor

@rabauss rabauss commented Jan 3, 2020

@Toflar Toflar requested a review from aschempp January 3, 2020 12:39
Toflar
Toflar previously approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@Toflar Toflar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I asked @aschempp for another review though :)

aschempp
aschempp previously approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@aschempp aschempp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably require a custom picker builder and/or a custom DC_Table, but there‘s no reason not to add the flexibility 👍🏻

@leofeyer leofeyer added this to the 4.9 milestone Jan 6, 2020
@rabauss @leofeyer
Update doc
65cdb43 
Co-Authored-By: Leo Feyer <github@contao.org>
@rabauss rabauss dismissed stale reviews from aschempp and Toflar via 65cdb43 January 7, 2020 10:26
@leofeyer leofeyer merged commit 03c84e7 into contao:master Jan 7, 2020
@leofeyer
Copy link
Member

leofeyer commented Jan 7, 2020

Thank you @rabauss.

@rabauss rabauss deleted the feature/picker branch January 8, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofeyer leofeyer leofeyer approved these changes

@Toflar Toflar Toflar left review comments

@aschempp aschempp aschempp left review comments

Assignees

@rabauss rabauss

Labels
feature
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rabauss @leofeyer @Toflar @aschempp