Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get universal picker url parameters via own method #1154

Merged
merged 2 commits into from Jan 7, 2020

Conversation

@rabauss
Copy link
Contributor

rabauss commented Jan 3, 2020

@Toflar Toflar requested a review from aschempp Jan 3, 2020
Copy link
Member

Toflar left a comment

LGTM 👍 I asked @aschempp for another review though :)

Copy link
Contributor

aschempp left a comment

It would probably require a custom picker builder and/or a custom DC_Table, but there‘s no reason not to add the flexibility 👍🏻

@leofeyer leofeyer added the feature label Jan 6, 2020
@leofeyer leofeyer added this to the 4.9 milestone Jan 6, 2020
Co-Authored-By: Leo Feyer <github@contao.org>
@rabauss rabauss dismissed stale reviews from aschempp and Toflar via 65cdb43 Jan 7, 2020
@leofeyer leofeyer merged commit 03c84e7 into contao:master Jan 7, 2020
9 checks passed
9 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
codecov/project 89.7% (+<.01%) compared to bf98745
Details
@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Jan 7, 2020

Thank you @rabauss.

@rabauss rabauss deleted the eikona-media:feature/picker branch Jan 8, 2020
Tastaturberuf pushed a commit to Tastaturberuf/contao that referenced this pull request Jan 13, 2020
Description
-----------

see: contao#579 (comment)

Commits
-------

f02c53d Get universal picker url parameters via own method
65cdb43 Update doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.