Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the obsolete container.autowiring.strict_mode parameter #1162

Merged
merged 2 commits into from Jan 9, 2020

Conversation

@aschempp
Copy link
Contributor

aschempp commented Jan 8, 2020

These parameters are on by default since Symfony 3.3
symfony/recipes#241

@aschempp aschempp added this to the 4.9 milestone Jan 8, 2020
@aschempp aschempp requested review from Toflar and leofeyer Jan 8, 2020
@aschempp aschempp self-assigned this Jan 8, 2020
@leofeyer leofeyer added the defect label Jan 8, 2020
@aschempp

This comment has been minimized.

Copy link
Contributor Author

aschempp commented Jan 8, 2020

I just noticed. Re-added, but the second parameter does not exist in 4.0 anymore

@Toflar
Toflar approved these changes Jan 9, 2020
@leofeyer leofeyer merged commit 0bb6227 into master Jan 9, 2020
9 checks passed
9 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
codecov/project 89.73% (-0.01%) compared to 10f7ea7
Details
@leofeyer leofeyer deleted the feature/obsolete-config branch Jan 9, 2020
@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Jan 9, 2020

Thank you @aschempp.

@leofeyer leofeyer changed the title Remove obsolete parameters Remove the obsolete container.autowiring.strict_mode parameter Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.