Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set the connection in the RememberMeRepository class #1181

Merged
merged 2 commits into from Jan 14, 2020

Conversation

@leofeyer
Copy link
Member

leofeyer commented Jan 14, 2020

It does not make sense to only set $this->connection if $registry->getConnection() returns a certain object instance, because we are never handling the case that it does not. 馃し鈥嶁檪

@leofeyer leofeyer added the defect label Jan 14, 2020
@leofeyer leofeyer added this to the 4.9 milestone Jan 14, 2020
@leofeyer leofeyer requested review from ausi, Toflar, bytehead, aschempp and fritzmg Jan 14, 2020
@leofeyer leofeyer self-assigned this Jan 14, 2020
@Toflar
Toflar approved these changes Jan 14, 2020
@m-vo
m-vo approved these changes Jan 14, 2020
@leofeyer leofeyer merged commit 275dd6a into master Jan 14, 2020
9 checks passed
9 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
codecov/project 89.64% (-0.1%) compared to a843cff
Details
@leofeyer leofeyer deleted the bugfix/rememberme-repository branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.