Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the text line height #1215

Merged
merged 9 commits into from Feb 10, 2020
Merged

Adjust the text line height #1215

merged 9 commits into from Feb 10, 2020

Conversation

@xchs
Copy link
Contributor

xchs commented Jan 18, 2020

Adjust the line height so that the help text is not clipped:

settings

xchs added 2 commits Jan 18, 2020
Fix the help text line height.
Fix the help text line height.
@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Jan 21, 2020

Which browser and OS are you using?

@xchs

This comment has been minimized.

Copy link
Contributor Author

xchs commented Jan 21, 2020

Which browser and OS are you using?

Tested with Firefox, Chrome and Edge on Windows 10.

@xchs xchs changed the title Adjust the help text line height Adjust the text line height Jan 22, 2020
xchs added 2 commits Jan 22, 2020
Adjust the line height in the system log.
Adjust the line height in the system log.
@xchs

This comment has been minimized.

Copy link
Contributor Author

xchs commented Jan 22, 2020

I have adjusted the line height in the system log, too.

system_log

[Tested with Firefox, Chrome and Edge on Windows 10.]

@leofeyer leofeyer added the defect label Jan 23, 2020
@leofeyer leofeyer added this to the 4.9 milestone Jan 23, 2020
@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Jan 23, 2020

We have to check thoroughly that this change does not reintroduce the problems discussed in #79.

@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Feb 4, 2020

Can you please check if the following adjustments fix the issue for the help text?

.tl_help, .tl_help a {
    margin-bottom: 0;
    line-height: 1.2; /* previously 1.25*/
    color: gray;
}
.tl_box h3, .tl_tbox h3, .tl_xpl h3 {
    margin: 0;
    padding-top: 13px; /* previously padding: 14px 0 1px */
    font-size: .875rem;
}
.tl_text, .tl_text_2, .tl_text_3, .tl_text_4, .tl_textarea, .tl_text_unit, .tl_text_trbl, .tl_text_interval {
    margin: 3px 0; /* previously 2px 0 */
    box-sizing: border-box;
    padding: 5px 6px 6px;
    border: 1px solid #aaa;
    border-radius: 2px;
    background-color: #fff;
    -moz-appearance: none;
    -webkit-appearance: none;
}
xchs added 4 commits Feb 4, 2020
Implement the proposed adjustments
Implement the proposed adjustments
Implement the proposed adjustments
Implement the proposed adjustments
@xchs

This comment has been minimized.

Copy link
Contributor Author

xchs commented Feb 4, 2020

The proposed adjustments are working fine. I have updated the PR accordingly.

@leofeyer leofeyer modified the milestones: 4.9, 4.8 Feb 7, 2020
@leofeyer leofeyer merged commit 34292a2 into contao:4.8 Feb 10, 2020
9 checks passed
9 checks passed
Coverage
Details
Coding Style
Details
PHP 7.1
Details
PHP 7.2
Details
PHP 7.3
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
codecov/project No report found to compare against
Details
@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Feb 10, 2020

Thank you @xchs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.