Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close the cursor of the statement object after the result set has been read #1281

Closed
wants to merge 1 commit into from

Conversation

@leofeyer
Copy link
Member

leofeyer commented Feb 4, 2020

Since we are no longer working with the PHP resource object in the Result class (see #1274 (comment)), it does not make sense to keep the cursor of the statement object open until the __destruct() method is called. We can close it right after we have read in the result set.

@leofeyer leofeyer added the defect label Feb 4, 2020
@leofeyer leofeyer added this to the 4.4 milestone Feb 4, 2020
@leofeyer leofeyer requested a review from contao/reviewers Feb 4, 2020
@leofeyer leofeyer self-assigned this Feb 4, 2020
Copy link
Contributor

aschempp left a comment

is this the first step to allow array data? 😁

@aschempp

This comment has been minimized.

Copy link
Contributor

aschempp commented Feb 7, 2020

I guess #1287 makes this obsolete 🙃

@leofeyer

This comment has been minimized.

Copy link
Member Author

leofeyer commented Feb 7, 2020

It sure does.

@leofeyer leofeyer closed this Feb 7, 2020
@leofeyer leofeyer deleted the bugfix/database-result branch Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.