Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear trusted devices when disabling 2FA #1322

Merged

Conversation

@bytehead
Copy link
Member

bytehead commented Feb 13, 2020

See #1309.

@bytehead bytehead self-assigned this Feb 13, 2020
@bytehead bytehead added the defect label Feb 13, 2020
@bytehead bytehead added this to the 4.9 milestone Feb 13, 2020
@bytehead bytehead requested a review from leofeyer Feb 13, 2020
@leofeyer leofeyer mentioned this pull request Feb 13, 2020
4 of 4 tasks complete
@bytehead bytehead requested a review from aschempp Feb 13, 2020
@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Feb 13, 2020

What about the backup codes? Are they removed as well?

@bytehead

This comment has been minimized.

Copy link
Member Author

bytehead commented Feb 13, 2020

Yes, see Line 195:
$user->backupCodes = null;

@bytehead bytehead force-pushed the bytehead:bugfix/2fa-clear-trusted-devices-on-2fa-disable branch from 5f72df6 to 63ae617 Feb 14, 2020
@leofeyer leofeyer merged commit eac4787 into contao:4.9 Feb 14, 2020
17 checks passed
17 checks passed
Coverage
Details
Coverage
Details
Coding Style
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.3
Details
PHP 7.4
Details
PHP 7.4
Details
Prefer Lowest
Details
Prefer Lowest
Details
Bundles
Details
Bundles
Details
Windows
Details
Windows
Details
codecov/project 90.15% (+0.00%) compared to a5feefc
Details
@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Feb 14, 2020

Thank you @bytehead

@leofeyer leofeyer changed the title Clear trusted devices when disabling 2fa Clear trusted devices when disabling 2FA Feb 14, 2020
@bytehead bytehead deleted the bytehead:bugfix/2fa-clear-trusted-devices-on-2fa-disable branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.