Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate the "show preview toolbar" title #1437

Merged
merged 3 commits into from Mar 3, 2020
Merged

Conversation

@richardhj
Copy link
Member

richardhj commented Feb 28, 2020

Fixes #1388.

richardhj added 2 commits Feb 28, 2020
Copy link
Contributor

aschempp left a comment

Maybe we should use the trans default domain in all these templates?

@leofeyer leofeyer added the defect label Feb 28, 2020
@leofeyer leofeyer added this to the 4.9 milestone Feb 28, 2020
@leofeyer leofeyer linked an issue that may be closed by this pull request Mar 3, 2020
@leofeyer leofeyer merged commit e378298 into contao:4.9 Mar 3, 2020
9 checks passed
9 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
codecov/project 90.35% remains the same compared to 9feb0b1
Details
@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Mar 3, 2020

Thank you @richardhj

@richardhj richardhj deleted the richardhj:patch-4 branch Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.