Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set host and language when generating navigation #1458

Merged
merged 1 commit into from Mar 2, 2020

Conversation

@aschempp
Copy link
Contributor

aschempp commented Mar 2, 2020

Currently, the host and language is only forwarded to the renderNavigation method if it's different than the current one. But I don't really see a point in that, why would it not always be passed on?

Also, the $language property isn't used at all anymore, it seems. Removing this condition is helpful to get rid of addLanguageToUrl stuff.

@aschempp aschempp added this to the 4.10 milestone Mar 2, 2020
@aschempp aschempp self-assigned this Mar 2, 2020
@leofeyer leofeyer removed the feature label Mar 2, 2020
@leofeyer leofeyer merged commit c294088 into contao:master Mar 2, 2020
9 checks passed
9 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
codecov/project Absolute coverage decreased by -0.01, only covered lines were removed
Details
@aschempp aschempp deleted the aschempp:feature/navigation-host-language branch Mar 2, 2020
@aschempp aschempp mentioned this pull request Mar 10, 2020
15 of 20 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.