Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting for fileTree and pageTree without orderField #1468

Merged
merged 6 commits into from Mar 6, 2020

Conversation

@ausi
Copy link
Member

ausi commented Mar 2, 2020

Instead of 'orderField' => 'orderSrc' we can now use 'isSortable' => true.

In cases where folders are selectable and the files can be sorted (isGallery and isDownloads) orderField is still required.

@ausi ausi added the feature label Mar 2, 2020
@ausi ausi added this to the 4.10 milestone Mar 2, 2020
@ausi ausi requested a review from contao/reviewers Mar 2, 2020
@ausi ausi self-assigned this Mar 2, 2020
@ausi ausi changed the title Sorting for fileTree and pageTree without oderField Sorting for fileTree and pageTree without orderField Mar 2, 2020
@ausi ausi force-pushed the ausi:feature/sorting-without-oder-field branch from 0e67094 to d9a79ba Mar 4, 2020
@leofeyer leofeyer force-pushed the ausi:feature/sorting-without-oder-field branch from 962a447 to 547d1ab Mar 6, 2020
@leofeyer leofeyer merged commit 7195ace into contao:master Mar 6, 2020
8 of 9 checks passed
8 of 9 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
codecov/project 89.86% (-0.48%) compared to 6d53b74
Details
@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Mar 6, 2020

Thank you @ausi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.