Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register custom types in functional tests #1475

Merged
merged 2 commits into from Mar 3, 2020

Conversation

@aschempp
Copy link
Contributor

aschempp commented Mar 2, 2020

Complements contao/test-case#4

@aschempp aschempp added the defect label Mar 2, 2020
@aschempp aschempp added this to the 4.9 milestone Mar 2, 2020
@aschempp aschempp requested a review from contao/reviewers Mar 2, 2020
@aschempp aschempp self-assigned this Mar 2, 2020
@aschempp aschempp changed the title Register custom types in functionl tests Register custom types in functional tests Mar 3, 2020
@bytehead

This comment has been minimized.

Copy link
Member

bytehead commented Mar 3, 2020

 An exception occured while establishing a connection to figure out your pla  
  tform version.                                                               
  You can circumvent this by setting a 'server_version' configuration value

Related to this change?

@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Mar 3, 2020

Yes, the PhpStan error is related to this change (see https://github.com/contao/contao/pull/1475/checks?check_run_id=482054004#step:6:6).

bytehead added a commit to bytehead/contao that referenced this pull request Mar 3, 2020
bytehead added a commit to bytehead/contao that referenced this pull request Mar 3, 2020
@bytehead

This comment has been minimized.

Copy link
Member

bytehead commented Mar 3, 2020

See #1478.

@leofeyer leofeyer merged commit e6dd214 into contao:4.9 Mar 3, 2020
9 checks passed
9 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
codecov/project 90.32% (+0.00%) compared to 03b9d3b
Details
@aschempp aschempp deleted the aschempp:bugfix/database-fixtures branch Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.