Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PHPStan level 4 #1476

Merged
merged 5 commits into from Mar 3, 2020
Merged

Enable PHPStan level 4 #1476

merged 5 commits into from Mar 3, 2020

Conversation

@bytehead
Copy link
Member

bytehead commented Mar 3, 2020

No description provided.

@bytehead bytehead added the defect label Mar 3, 2020
@bytehead bytehead added this to the 4.10 milestone Mar 3, 2020
@bytehead bytehead self-assigned this Mar 3, 2020
bytehead and others added 4 commits Mar 3, 2020
@leofeyer leofeyer changed the title [RFC] Enable level 4 for PHPStan Enable level 4 for PHPStan Mar 3, 2020
@leofeyer leofeyer added feature and removed defect labels Mar 3, 2020
@leofeyer leofeyer changed the title Enable level 4 for PHPStan Enable PHPStan level 4 Mar 3, 2020
@leofeyer leofeyer merged commit eff34c1 into contao:master Mar 3, 2020
9 checks passed
9 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
codecov/project 90.38% (+0.03%) compared to c8ec50e
Details
@bytehead bytehead deleted the bytehead:fix/phpstan-level4 branch Mar 3, 2020
leofeyer pushed a commit that referenced this pull request Mar 3, 2020
Description
-----------

| Q                | A
| -----------------| ---
| Fixed issues     | n/a
| Docs PR or issue | n/a

Run PHPStan on level 4 in CI. Missed this in #1476.

Commits
-------

26af1a6 Run PHPStan on level 4 in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.