Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore the routing test in Psalm #1514

Merged
merged 1 commit into from Mar 10, 2020
Merged

Ignore the routing test in Psalm #1514

merged 1 commit into from Mar 10, 2020

Conversation

@leofeyer
Copy link
Member

leofeyer commented Mar 10, 2020

Q A
Fixed issues -
Docs PR or issue -

Psalm does not handle Symfony's ForwardCompatTestTrait definition inside the if-else statements.

@leofeyer leofeyer added the defect label Mar 10, 2020
@leofeyer leofeyer added this to the 4.10 milestone Mar 10, 2020
@leofeyer leofeyer requested a review from contao/reviewers Mar 10, 2020
@leofeyer leofeyer self-assigned this Mar 10, 2020
@Toflar
Toflar approved these changes Mar 10, 2020
@leofeyer leofeyer merged commit e394848 into contao:master Mar 10, 2020
9 checks passed
9 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
codecov/project 89.86% remains the same compared to 8ba73b8
Details
@leofeyer leofeyer deleted the leofeyer:fix/psalm branch Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.