Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the sorting of the selected IDs for actions #1542

Merged
merged 1 commit into from Mar 30, 2020

Conversation

@rabauss
Copy link
Contributor

rabauss commented Mar 19, 2020

During copyAll we had the problem that the sorting was lost,
because the CLIPBOARD is filtered according to element permissions.

I'm not sure, if it's also neccesary for actions other than copyAll, but I have seen a similar logic there.

@aschempp aschempp added the defect label Mar 19, 2020
@aschempp

This comment has been minimized.

Copy link
Contributor

aschempp commented Mar 19, 2020

is the issue not present in Contao 4.4 (then the PR should be based on the 4.4 branch)?

@rabauss

This comment has been minimized.

Copy link
Contributor Author

rabauss commented Mar 19, 2020

No it's only in 4.9 because of ce_access!

@Toflar Toflar added this to the 4.9 milestone Mar 19, 2020
@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Mar 23, 2020

@rabauss Can you please rebase the PR onto the latest 4.9 branch? This should fix the CI chain.

@rabauss rabauss force-pushed the eikona-media:feature/filterContentElements branch from d111c65 to 481a1a0 Mar 23, 2020
@rabauss

This comment has been minimized.

Copy link
Contributor Author

rabauss commented Mar 23, 2020

I'm always not sure if I have to force push after rebase. But I guess because of that the review status got lost.

@m-vo

This comment has been minimized.

Copy link
Contributor

m-vo commented Mar 24, 2020

Rebasing rewrites your commit history (i.e. creating new commits), so you can never push without --force.

@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Mar 24, 2020

But I guess because of that the review status got lost.

This happened on purpose, because we have configured it this way.

@leofeyer leofeyer merged commit 5dab841 into contao:4.9 Mar 30, 2020
8 checks passed
8 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Mar 30, 2020

Thank you @rabauss.

@rabauss rabauss deleted the eikona-media:feature/filterContentElements branch Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.