Add SCSS source maps in debug mode

[denniserdmann]

The SCSS-Compiler has an option to generate Source Maps for generated CSS files, see https://scssphp.github.io/scssphp/docs/#source-maps

It would be nice to have Source Maps activated, when Contao Debug Mode is activated, too. A basic solution could be adding an inline source map, but there are also options to generate a separate file.

What do you think?

[richardhj]

It is a simple change that is helping for legacy themes (themes that do not use a gulp or encore workflow) and only runs in dev mode, so +1 from my side.

[aschempp]

I‘m in favor of always having source maps. They don‘t harm, and they make the minified code readable.

https://m.signalvnoise.com/paying-tribute-to-the-web-with-view-source/

[denniserdmann]

I agree, unless there are no perfomance downsides.

[leofeyer]

Is this a bugfix or a new feature?

[aschempp]

Sounds like a feature to me

[denniserdmann]

me, too. Although it would be nice to have in the current LTS

[leofeyer]

@contao/developers I guess we could add this in Contao 4.9, couldn't we?

@denniserdmann Can you please take care of the failing CI checks?

[ausi]

Is this a bugfix or a new feature?

IMO it’s a bugfix, source maps should have been activated ever since.

I guess we could add this in Contao 4.9, couldn't we?

👍

[denniserdmann]

Can you please take care of the failing CI checks?

@leofeyer tried my best, but i'm not sure how these checks are working. Changed the file, but error is still there.

[leofeyer]

You should run composer run cs-fixer in your local fork. It will fix the code automatically.

[denniserdmann]

You should run composer run cs-fixer in your local fork. It will fix the code automatically.

What, if i don't have a local fork? ;-)

Yes, I can install it, but i thought there would be an easier way, as made my propose „one the fly“.

[rabauss]

Correct formating would be like this:

        if (Config::get('debugMode')) {
            $objCompiler->setSourceMap(Compiler::SOURCE_MAP_INLINE);
        }

[leofeyer]

Thank you @denniserdmann.