Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more recent Doctrine versions in the composer.json #1890

Merged
merged 2 commits into from Jul 3, 2020

Conversation

leofeyer
Copy link
Member

@leofeyer leofeyer commented Jul 1, 2020

This is a first step to implement #1889.

@aschempp The SchemaProviderInterface no longer exists in version 2 and 3 of the migrations bundle. I have tried to trace the usage of our MigrationsSchemaProvider class, however, it seems that it is not used anymore. Is it a left-over from Contao 4.4?

@ausi Does it make sense to drop support for version 1 of the migrations bundle?

@leofeyer leofeyer added this to the 4.10 milestone Jul 1, 2020
@leofeyer leofeyer requested a review from a team July 1, 2020 16:36
@leofeyer leofeyer self-assigned this Jul 1, 2020
@aschempp
Copy link
Member

aschempp commented Jul 1, 2020

The MigrationsSchemaProvider is only used as an interface „decorator“. As we are still compatible with old bundle versions, are you sure its not needed for these?

@leofeyer
Copy link
Member Author

leofeyer commented Jul 2, 2020

No idea TBH. What about dropping support for version 1 entirely?

@leofeyer
Copy link
Member Author

leofeyer commented Jul 2, 2020

As discussed in Mumble on July 2nd, we can remove the doctrine/doctrine-migrations-bundle dependency altogether, as we now always have ORM (see #516). Removed in 78fc5c1.

@leofeyer leofeyer requested review from a team and removed request for a team July 3, 2020 07:02
@leofeyer leofeyer merged commit 3651d69 into contao:master Jul 3, 2020
@leofeyer leofeyer deleted the feature/doctrine branch July 3, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants