Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the class name as cache key in System::import() #2153

Merged
merged 2 commits into from Aug 13, 2020
Merged

Use the class name as cache key in System::import() #2153

merged 2 commits into from Aug 13, 2020

Conversation

leofeyer
Copy link
Member

Q A
Fixed issues Fixes #2152
Docs PR or issue -

@leofeyer leofeyer added the bug label Aug 13, 2020
@leofeyer leofeyer added this to the 4.9 milestone Aug 13, 2020
@leofeyer leofeyer self-assigned this Aug 13, 2020
@leofeyer leofeyer linked an issue Aug 13, 2020 that may be closed by this pull request
System::import() may return unexpected instances #2152
Closed
@leofeyer leofeyer requested a review from aschempp August 13, 2020 09:57
@bytehead bytehead changed the title Use the class name as chache key in System::import() Use the class name as cache key in System::import() Aug 13, 2020
@leofeyer leofeyer merged commit 75482d5 into contao:4.9 Aug 13, 2020
@leofeyer leofeyer deleted the fix/system-import branch August 13, 2020 13:48
@dmolineus dmolineus mentioned this pull request Aug 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bytehead bytehead bytehead approved these changes

@aschempp aschempp aschempp approved these changes

@dmolineus dmolineus dmolineus approved these changes

@ausi ausi Awaiting requested review from ausi

Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

System::import() may return unexpected instances
4 participants
@leofeyer @bytehead @aschempp @dmolineus