Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM] add splash image to vimeo & youtube elements #300

Merged
merged 7 commits into from May 9, 2019

Conversation

Projects
None yet
3 participants
@fritzmg
Copy link
Contributor

commented Jan 26, 2019

One of the more frequently requested features for Contao 4.6 and up from the https://github.com/friends-of-contao/contao-privacy extension is the ability to use a splash image for YouTube and Vimeo video elements, to prevent client connections to these services upon visiting the Contao website.

Since the future of that extension regarding Contao 4.6 and up is unclear, I think it would make sense to integrate this feature into the core.

screenshot_2019-01-26 articles home content elements edit content element id 11 - contao open source cms

@fritzmg

This comment has been minimized.

Copy link
Contributor Author

commented Jan 26, 2019

Or should we put the JavaScript into a j_splash_image template file and add a back end notice, similar to the one for the video player element, when the splash image option is enabled?

@ausi

This comment has been minimized.

Copy link
Member

commented Jan 26, 2019

I don’t think so. An inline script is the right choice here IMO.

@ausi

ausi approved these changes Jan 26, 2019

@fritzmg fritzmg changed the title [RFC] add splash image to vimeo & youtube elements [RTM] add splash image to vimeo & youtube elements Jan 26, 2019

@leofeyer leofeyer added the feature label Jan 26, 2019

@leofeyer leofeyer added this to the 4.8.0 milestone Jan 26, 2019

@leofeyer leofeyer force-pushed the contao:master branch 3 times, most recently from ce9e981 to 8b4b00d Feb 18, 2019

@leofeyer leofeyer force-pushed the contao:master branch from 804d2ed to c0fc631 Mar 27, 2019

@leofeyer

This comment has been minimized.

Copy link
Member

commented May 9, 2019

@fritzmg If you agree with my changes, I would merge this PR now.

@fritzmg

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

👍 :)

@leofeyer leofeyer merged commit f0898ba into contao:master May 9, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 88.73%
Details
@leofeyer

This comment has been minimized.

Copy link
Member

commented May 9, 2019

Thank you @fritzmg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.