Check if a service was removed from the container at compile time

[aschempp]

I realized there's actually a way to check if a service was removed at compile time, so we can check for that instead of assuming we need to create an instance if there are no constructor arguments.

Also updated the error message to match Symfony.

[Toflar]

Neat!

[Toflar]

Neat!

[leofeyer]

I don't think the instanceof Container check is necessary. We are not checking this above and below, either.

[aschempp]

getRemovedIds is not part of the interface, it has only been in the class since Symfony 3.4

[leofeyer]

Shouldn't we check \in_array('getRemovedIds', get_class_methods($container), true) then?

[aschempp]

No, we require 3.4 minimum.

[leofeyer]

What has that to do with it? We are checking for method existence in other places, too, e.g. here: https://github.com/contao/contao/blob/4.4/core-bundle/src/Doctrine/Schema/DcaSchemaProvider.php#L317

[ausi]

IMO the instanceof check is correct here. The existence of getRemovedIds() doesn’t guarantee that it works as we expect it, but the BC promise of Symfony should guarantee that the Container class works as expected.

[aschempp]

We're checking for the method existence because there can be differences in our dependencies. Not so in the case, the method must always be there if that class is implemented (which we actually know it is, but the interface does not guarantee that).

[leofeyer]

Thank you @aschempp.