Do not show the urlattr flag for rgxp url fields #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toflar
approved these changes
Aug 12, 2021
|
Thank you @ausi. |
ausi
added a commit
to ausi/contao-contao
that referenced
this pull request
Aug 17, 2021
Description ----------- When saving `rgxp => url` fields we add the `urlattr` flag in https://github.com/contao/contao/blob/6a676204294a2613013bfb88a1be8d4247ac2254/core-bundle/src/Resources/contao/library/Contao/Widget.php#L983-L984 This pull request does the counterpart by removing it when the value is shown to the user. Related: https://community.contao.org/de/showthread.php?81418 Commits ------- c7fd006 Do not show the urlattr flag for rgxp url fields
leofeyer
pushed a commit
that referenced
this pull request
Aug 20, 2021
Description ----------- Backport of #3293 Commits ------- 505223b Do not show the urlattr flag for rgxp url fields (see #3293) Description ----------- When saving `rgxp => url` fields we add the `urlattr` flag in https://github.com/contao/contao/blob/6a676204294a2613013bfb88a1be8d4247ac2254/core-bundle/src/Resources/contao/library/Contao/Widget.php#L983-L984 This pull request does the counterpart by removing it when the value is shown to the user. Related: https://community.contao.org/de/showthread.php?81418 Commits ------- c7fd006 Do not show the urlattr flag for rgxp url fields
bezin
pushed a commit
to bezin/contao
that referenced
this pull request
Nov 26, 2021
Description ----------- When saving `rgxp => url` fields we add the `urlattr` flag in https://github.com/contao/contao/blob/6a676204294a2613013bfb88a1be8d4247ac2254/core-bundle/src/Resources/contao/library/Contao/Widget.php#L983-L984 This pull request does the counterpart by removing it when the value is shown to the user. Related: https://community.contao.org/de/showthread.php?81418 Commits ------- c7fd006 Do not show the urlattr flag for rgxp url fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving
rgxp => urlfields we add theurlattrflag incontao/core-bundle/src/Resources/contao/library/Contao/Widget.php
Lines 983 to 984 in 6a67620
This pull request does the counterpart by removing it when the value is shown to the user.
Related: https://community.contao.org/de/showthread.php?81418