Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the default quote style #3383

Merged
merged 1 commit into from Aug 25, 2021
Merged

Fix the default quote style #3383

merged 1 commit into from Aug 25, 2021

Conversation

leofeyer
Copy link
Member

We had to change ENT_COMPAT to ENT_QUOTES everywhere in order to fix the latest security vulnerability. However, we forgot to also change the StringUtil::decodeEntities() default value.

@leofeyer leofeyer added the bug label Aug 25, 2021
@leofeyer leofeyer added this to the 4.9 milestone Aug 25, 2021
@leofeyer leofeyer requested a review from a team August 25, 2021 10:22
@leofeyer leofeyer self-assigned this Aug 25, 2021
@leofeyer leofeyer merged commit 214825c into contao:4.9 Aug 25, 2021
@leofeyer leofeyer deleted the fix/quote-style branch August 25, 2021 11:33
bezin pushed a commit to bezin/contao that referenced this pull request Nov 26, 2021
Description
-----------

We had to change `ENT_COMPAT` to `ENT_QUOTES` everywhere in order to fix the latest security vulnerability. However, we forgot to also change the `StringUtil::decodeEntities()` default value.

Commits
-------

47375a1 Fix the default quote style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants