Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Got rid of the header-replay-bundle #365

Merged
merged 3 commits into from Feb 22, 2019

Conversation

@Toflar
Copy link
Member

commented Feb 20, 2019

Well, here we are. It's been a nice ride dear header-replay-bundle. You've taught us a lot about caching but it's time to make Contao faster and easier to debug and understand.

Thank you for your service over the last two years.
Bye, bye 馃憢

$this->addSubscriber(new CleanupCacheTagsListener());
}
public function wasCacheCircumvented(): bool

This comment has been minimized.

Copy link
@Toflar

Toflar Feb 20, 2019

Author Member

You might wonder why I did not mock the kernel and check if ->handle() was called or not. I did do this initially but it doesn't really work. I only want to check if our ContaoCache does what it's supposed to do. If a private request comes in ->kernel->handle() should not be called, thus you would set ->expects($this->never()) but that will actually not work because the request will flow through the HttpCache that has no cache entry eventually being forward()ed again to the the kernel so that expectation would fail 馃槃

@aschempp aschempp referenced this pull request Feb 20, 2019
10 of 10 tasks complete
Toflar added 2 commits Feb 21, 2019
@Toflar

This comment has been minimized.

Copy link
Member Author

commented Feb 21, 2019

The one failing test is unrelated and also happens in master.

@leofeyer leofeyer added the feature label Feb 22, 2019

@leofeyer leofeyer added this to the 4.8.0 milestone Feb 22, 2019

@leofeyer leofeyer merged commit 95e35ee into contao:master Feb 22, 2019

1 of 3 checks passed

Travis CI - Pull Request Build Failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
coverage/coveralls Coverage increased (+0.05%) to 88.208%
Details
@leofeyer

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

Thank you @Toflar. And thank you for having created the header-replay-bundle in the first place 鈥撀爄t was a good solution for a problem that we could not have fixed at the time otherwise.

@Toflar Toflar deleted the Toflar:feature/bye-bye-header-replay branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.