Always show debug log and fetch crawl status earlier #3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofeyer
approved these changes
Dec 13, 2021
|
Thank you @Toflar. |
leofeyer
added a commit
that referenced
this pull request
Nov 3, 2023
Description ----------- In #3804 we have introduced the feature that the debug log download button is always shown when the crawler is running. This has been accidentally removed in #4845 by @leofeyer when adjusting the styling. @leofeyer not sure these styles are fine for you now so feel free to review the looks again but the download button should be shown 😄 Commits ------- 04e005b Fixed debug log not shown when crawler is running 85aa6e3 CSS adjustments Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
leofeyer
added a commit
to contao/core-bundle
that referenced
this pull request
Nov 3, 2023
Description ----------- In contao/contao#3804 we have introduced the feature that the debug log download button is always shown when the crawler is running. This has been accidentally removed in contao/contao#4845 by @leofeyer when adjusting the styling. @leofeyer not sure these styles are fine for you now so feel free to review the looks again but the download button should be shown 😄 Commits ------- 04e005b9 Fixed debug log not shown when crawler is running 85aa6e30 CSS adjustments Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to always download the crawl debug log file even while the crawler is running and it also fixes #1371 because it actually always continued on page reload, you just could only see the current status after the first crawl process which might take 10 - 20 seconds depending on the settings.
This is solved now by simply executing the first ajax request without actually initiating the crawl process.