Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the hasText/hasDetails usage #4668

Merged
merged 1 commit into from May 13, 2022
Merged

Conversation

leofeyer
Copy link
Member

@leofeyer leofeyer commented May 13, 2022

We must not tread hasText and hasDetails as callables, because they can also be booleans. And if that is the case, an InvalidArgumentException: hasDetails is not set or not a callable exception will be triggered.

@leofeyer leofeyer added the bug label May 13, 2022
@leofeyer leofeyer added this to the 4.13 milestone May 13, 2022
@leofeyer leofeyer self-assigned this May 13, 2022
@leofeyer leofeyer requested a review from a team May 13, 2022 08:24
@leofeyer leofeyer merged commit bb33c27 into contao:4.13 May 13, 2022
@leofeyer leofeyer deleted the fix/has-details branch May 13, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants