Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tablesort.js 4 (supports localStorage) #471

Merged
merged 2 commits into from May 6, 2019

Conversation

Projects
None yet
2 participants
@leofeyer
Copy link
Member

commented May 3, 2019

This PR updates contao-components/tablesort to version 4 (see #459). It now uses localStorage instead of cookies and reads the default sorting from the data-sort-default attribute.

@leofeyer leofeyer added the feature label May 3, 2019

@leofeyer leofeyer added this to the 4.8.0 milestone May 3, 2019

@leofeyer leofeyer requested a review from Toflar May 3, 2019

@leofeyer leofeyer self-assigned this May 3, 2019

@Toflar

Toflar approved these changes May 3, 2019

Copy link
Member

left a comment

Nice work!!

@leofeyer leofeyer merged commit 945fd7e into master May 6, 2019

0 of 4 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Failed
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

@leofeyer leofeyer deleted the feature/tablesort-local-storage branch May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.