Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern fragments: video content elements #4823

Merged
merged 6 commits into from Jul 12, 2022

Conversation

m-vo
Copy link
Member

@m-vo m-vo commented Jun 11, 2022

Followup to #4810

This PR adds the video content elements…

  • content_element/vimeo
  • content_element/youtube

… together with a generic _splash_screen.html.twig component.

Note: This PR is currently based on #4810; needs to be rebased once merged.

@m-vo m-vo added the feature label Jun 11, 2022
@m-vo m-vo added this to the 5.0 milestone Jun 11, 2022
@m-vo m-vo self-assigned this Jun 11, 2022
m-vo added a commit to m-vo/contao that referenced this pull request Jun 22, 2022
@m-vo m-vo force-pushed the twig/content-elements/video branch from a74f96e to 4f97cb9 Compare June 28, 2022 11:27
@m-vo m-vo force-pushed the twig/content-elements/video branch from 4f97cb9 to 8f3087a Compare June 28, 2022 13:35
@m-vo m-vo requested a review from ausi June 29, 2022 09:19
@m-vo m-vo mentioned this pull request Jul 1, 2022
@leofeyer leofeyer linked an issue Jul 12, 2022 that may be closed by this pull request
@leofeyer leofeyer enabled auto-merge (squash) July 12, 2022 10:34
@leofeyer
Copy link
Member

Thank you @m-vo.

@leofeyer leofeyer merged commit a790aa6 into contao:5.x Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a play button and GDPR hint to splash images
2 participants