Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create new DC objects in the reviseTable() method #485

Merged
merged 1 commit into from May 13, 2019

Conversation

Projects
None yet
2 participants
@leofeyer
Copy link
Member

commented May 13, 2019

As discussed in #455, this PR overwrites the ID and active records of the existing DC object in the reviseTable() method instead of creating new DC objects.

@leofeyer leofeyer added the defect label May 13, 2019

@leofeyer leofeyer added this to the 4.7.6 milestone May 13, 2019

@leofeyer leofeyer requested a review from Toflar May 13, 2019

@leofeyer leofeyer self-assigned this May 13, 2019

@Toflar

Toflar approved these changes May 13, 2019

@leofeyer leofeyer merged commit cdb4017 into 4.7 May 13, 2019

5 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 88.947%
Details

@leofeyer leofeyer deleted the hotfix/revise-table branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.