New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the order of the palette combiner #5271
Merged
leofeyer
merged 7 commits into
contao:4.9
from
ausi:fix/data-container-palette-combiner
Sep 15, 2022
Merged
Fix the order of the palette combiner #5271
leofeyer
merged 7 commits into
contao:4.9
from
ausi:fix/data-container-palette-combiner
Sep 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ausi
commented
Sep 13, 2022
Looks like this issue was introduced by #5154 cc @dennisbohn So an alternative fix would be to wrap the |
👍 for the alternative fix. |
Thank you for fixing this. |
leofeyer
previously approved these changes
Sep 15, 2022
leofeyer
force-pushed
the
fix/data-container-palette-combiner
branch
from
September 15, 2022 07:17
7dd1052
to
856201d
Compare
leofeyer
reviewed
Sep 15, 2022
leofeyer
approved these changes
Sep 15, 2022
Thank you @ausi. |
leofeyer
changed the title
Fix order of palette combiner
Fix the order of the palette combiner
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently having two selectors (
palettes.__selector__
) where one has the valuefoo
and the otherbar
the palettefoobar
gets used as expected.But if another selector appears before them in the
__selector__
array that has a value ofnull
,false
or''
now the palettfoo
gets selected which is unexpected IMO.This issue currently exists for example the
tl_module.rocksolid_sliderrsts_default
palette when installingmadeyourday/contao-rocksolid-slider
together withalnv/catalog-manager
.This PR solves this by skipping empty values when generating the palette names.