Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track profiler messages in the Contao translator #544

Merged
merged 8 commits into from Jul 10, 2019

Conversation

Projects
None yet
2 participants
@aschempp
Copy link
Contributor

commented Jul 2, 2019

Implements #317

Currently does not track "fallback messages", but thats very hard in Contao. The only way I can see would be to always load english and then re-load the actual language, but that seems kinda overkill…

@aschempp aschempp added the feature label Jul 2, 2019

@aschempp aschempp added this to the 4.8 milestone Jul 2, 2019

@leofeyer

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

but that seems kinda overkill…

Agreed.

@leofeyer leofeyer force-pushed the feature/translator-data-collector branch from 6867422 to 589c801 Jul 10, 2019

@leofeyer leofeyer force-pushed the feature/translator-data-collector branch from 56d74f7 to 2cf5847 Jul 10, 2019

leofeyer added some commits Jul 10, 2019

@leofeyer leofeyer force-pushed the master branch 2 times, most recently from b2174a9 to 8728020 Jul 10, 2019

@leofeyer leofeyer merged commit f11e59d into master Jul 10, 2019

5 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls First build on feature/translator-data-collector at 87.349%
Details
@leofeyer

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

Thank you @aschempp.

@leofeyer leofeyer deleted the feature/translator-data-collector branch Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.