Add a favorites menu in the back end

[leofeyer]

Implements #5401

TODO

• Unit tests
• Check permissions

[Toflar]

Wohey, apart from the code reviews, I've checked out the branch and tested it. I've noticed that when I am on a page that is already a favorite, I can still add it as a favorite again - that doesn't make sense, don't you think?

Looks pretty good already, though! 🥳

[leofeyer]

I've noticed that when I am on a page that is already a favorite, I can still add it as a favorite again - that doesn't make sense, don't you think?

Changed in b3cc8a9.

[leofeyer]

This one is ready for review again. 😉

[Toflar]

Look how beautiful this code has turned out with the new permission voter ❤️

I think I can approve this. I have just two UX remarks which I noticed using the feature that are debatable and you might want to look into or also not:

1. If somehow possible it would be great if the favorite had a default title when I add a new one.
2. Not sure if it's good to remove the icon from the navigation when already added. It makes the navigation change all the time when I navigate. Maybe disabling it with a different icon indicating that you cannot click would be better.

Again not sure for both. Both can also be changed or added later on. I just wanted to leave the remarks here.

[leofeyer]

I have implemented no. 2 in 7a2f03d.

Now if a URL is a favorite already, the symbol changes and clicking it takes you to the favorites module:

No. 1 is unfortunately much harder to implement. The best predefined value would be the page title, however, since we do not have a request context in the back end, I cannot retrieve it in the listener. We may have to open a separate issue and discuss this in the next call.

[Toflar]

The navigation feels way better (to me) now! Thanks!

Regarding the tilte: Sure, that's something we can still improve.

[contaoacademy]

Awesome, thanks for the implementation