Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get pagetree picker url parameters via own method #580

Merged
merged 3 commits into from Jan 9, 2020

Conversation

@rabauss
Copy link
Contributor

rabauss commented Jul 14, 2019

Get the picker url parameters via own method, to get the possibility to overwrite/extend it in own extensions.

Sorry for the second PR, just didn't want to use my feature for filetree.
After #579 I just realized, that in pagetree is similar logic.

@rabauss rabauss changed the title get picker url parameters via own method Get pagetree picker url parameters via own method Jul 14, 2019
@leofeyer leofeyer added the feature label Jul 23, 2019
@leofeyer leofeyer added this to the 4.9 milestone Jul 23, 2019
@leofeyer leofeyer force-pushed the contao:master branch from 2ea6ebd to 91d73a0 Sep 26, 2019
@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Jan 2, 2020

@rabauss @aschempp What is the status of this PR now that we have added a universal picker in #714?

@rabauss rabauss force-pushed the eikona-media:feature/pagetree branch from cdd98f8 to 7ed84e1 Jan 3, 2020
Co-Authored-By: Leo Feyer <github@contao.org>
@aschempp aschempp requested a review from leofeyer Jan 9, 2020
@leofeyer leofeyer merged commit 4260dbd into contao:master Jan 9, 2020
9 checks passed
9 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
codecov/project 89.73% (+0.03%) compared to bf98745
Details
@rabauss rabauss deleted the eikona-media:feature/pagetree branch Jan 9, 2020
Tastaturberuf pushed a commit to Tastaturberuf/contao that referenced this pull request Jan 13, 2020
Description
-----------

Get the picker url parameters via own method, to get the possibility to overwrite/extend it in own extensions.

Sorry for the second PR, just didn't want to use my feature for filetree.
After contao#579 I just realized, that in pagetree is similar logic.

Commits
-------

85de3ad get picker url parameters via own method
7ed84e1 cs fix
c4935b1 Update core-bundle/src/Resources/contao/widgets/PageTree.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.